Skip to content
This repository has been archived by the owner on Jan 31, 2024. It is now read-only.

build error related to megalodon #111

Closed
tastytea opened this issue Oct 23, 2023 · 3 comments
Closed

build error related to megalodon #111

tastytea opened this issue Oct 23, 2023 · 3 comments

Comments

@tastytea
Copy link

the issue was already reported but the solution was not shared.

💡 Summary

the build process errors when coming to packages/megalodon. i'm using the build instructions on misskey-hub since i didn't find sharkey specific instructions.

🥰 Expected Behavior

build succeeds

🤬 Actual Behavior

excerpt of the errors:

packages/megalodon build: src/friendica.ts(3,29): error TS7016: Could not find a declaration file for module 'parse-link-header'. '/opt/misskey/sharkey/node_modules/.pnpm/[email protected]/node_modules/parse-link-header/index.js' implicitly has an 'any' type.
packages/megalodon build:   Try `npm i --save-dev @types/parse-link-header` if it exists or add a new declaration (.d.ts) file containing `declare module 'parse-link-header';`

full build log

📝 Steps to Reproduce

  1. check out fresh sharkey stable branch
  2. git submodule update --init
  3. NODE_ENV=production pnpm install --frozen-lockfile
  4. NODE_ENV=production pnpm run build

📌 Environment

🛰 Backend (for server admin)

  • Installation Method or Hosting Service: manual
  • Sharkey: stable branch
  • Node: 20.6.1
  • PostgreSQL: 15.4
  • Redis: 7.2.1
  • OS and Architecture: Gentoo Linux amd64
@Mar0xy
Copy link
Contributor

Mar0xy commented Oct 23, 2023

Please use install without NODE_ENV as obviously dev packages like typing don't get installed then

@transfem-org transfem-org deleted a comment from Insert5StarName Oct 23, 2023
@tastytea
Copy link
Author

thanks, that worked. i don't see how this would be obvious to someone who doesn't program with nodejs though.

@Mar0xy
Copy link
Contributor

Mar0xy commented Oct 23, 2023

This issue will be gone after the rewrite of the Mastodon API as megalodon will be dropped out of the packages that are needed then.

Mar0xy pushed a commit that referenced this issue Oct 28, 2023
Fixes User and Notes count bug (#113)
Fixes build issues due to types (#111)
Return accounts and notes like Iceshrimp
Use MFM class from Iceshrimp to fix HTML output for mastodon
moyitpro pushed a commit to chikorita157/Sakurakey that referenced this issue Oct 28, 2023
Fixes User and Notes count bug (transfem-org#113)
Fixes build issues due to types (transfem-org#111)
Return accounts and notes like Iceshrimp
Use MFM class from Iceshrimp to fix HTML output for mastodon
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants