Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tech object curly newline to consistent #16

Merged
merged 2 commits into from
Jul 26, 2018

Conversation

hubertmine
Copy link
Contributor

  • Removed ecmaFeature because of deprecation warning
  • Added object-curly-newline consistent true rule
function foo({ a, b, c}) {
    // some stuff
}

caused linting error and required to be broken to the line.
Consistent requires that if there is a line break, then the other curly brace be put on a new line as well.

Copy link

@ygrandmaitre ygrandmaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
😎

@hubertmine hubertmine merged commit 21e408f into master Jul 26, 2018
@hubertmine hubertmine deleted the TECH-Object-curly-newline-to-consistent branch July 26, 2018 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants