OPE-10714 Use SENTRY_ENVIRONMENT instead of NODE_ENV to set Sentry Environment #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vironment Using NODE_ENV was a mistake from the start.
Codecov Report
@@ Coverage Diff @@
## master #37 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 4
Lines 39 39
=========================================
Hits 39 39
Continue to review full report at Codecov.
|
Antoninbln
approved these changes
Jun 23, 2020
There was a problem hiding this comment.
Could you update the version defined in package.json, and define the release here please ?
Then we'll be able to publish the package update :)
Otherwise it LGTM 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
NODE_ENVwas a mistake from the start.NODE_ENVshould only be used to configure NodeJS.SENTRY_ENVIRONMENTlets use configure different environments in Sentry using the same DSN.