Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TECH revert credentials obfuscation #34

Merged
merged 1 commit into from
Oct 4, 2019
Merged

TECH revert credentials obfuscation #34

merged 1 commit into from
Oct 4, 2019

Conversation

Antoninbln
Copy link
Contributor

Purpose of this PR

Revert of credentials obfuscation merge in master, we decided to change the way we do that.

PR

Revert "Merge pull request #33 from transcovo/PLAT-639-offuscate-cred…
757539c 
…entials"

This reverts commit 608c4a3, reversing
changes made to 9648ed5.
@Antoninbln Antoninbln requested a review from a team August 9, 2019 11:23
@codecov
Copy link

codecov bot commented Aug 9, 2019 •
edited
Loading

Codecov Report

Merging #34 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #34   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           4      4           
  Lines          42     39    -3     
=====================================
- Hits           42     39    -3
Impacted Files Coverage Δ
index.js 100% <ø> (ø) ⬆️
streams/sensitive-data.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 608c4a3...757539c. Read the comment docs.

ygrandmaitre
ygrandmaitre approved these changes Aug 9, 2019
View reviewed changes
Copy link
Contributor

@ygrandmaitre ygrandmaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Antoninbln Antoninbln merged commit 8e217c1 into master Oct 4, 2019
@JulienJourdain JulienJourdain deleted the revert-obfuscate-credentials branch December 16, 2019 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ygrandmaitre ygrandmaitre ygrandmaitre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Antoninbln @ygrandmaitre