Attempt to fix Cypress flakes #5353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monfresh
force-pushed
the
mb-cypress-flakes
branch
from
bcffd87
to
3e3b983
Compare
For some reason, we are making two requests on the TXO pages: one with page, per page, and order, and then a second request with the same params, but this time with sort added to the mix. Because we were using a glob to match all requests to the TXO endpoints, calling cy.wait will stop at the first match, and will not also wait for the second request. I added a second named route to match the second request, and we are now waiting for that one as well.
monfresh
force-pushed
the
mb-cypress-flakes
branch
from
3e3b983
to
71a145e
Compare
abbyoung
approved these changes
Nov 26, 2020
donaldthai
reviewed
Nov 26, 2020
| @@ -42,7 +45,7 @@ describe('TIO user', () => { | |||
| const paymentRequestId = 'ea945ab7-099a-4819-82de-6968efe131dc'; | |||
|
|
|||
| // TIO Payment Requests queue | |||
| cy.wait(['@getGHCClient', '@getPaymentRequests']); | |||
| cy.wait(['@getGHCClient', '@getPaymentRequests', '@getSortedPaymentRequests']); | |||
There was a problem hiding this comment.
Adding another route works in this case. There's another way to wait for a number of the same requests instead of creating a new route.
Something like this:
cy.wait(['@getPaymentRequests', '@getPaymentRequests']);There was a problem hiding this comment.
Oh, interesting! I prefer that waitTimes custom command. Maybe we can try that next week.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, we are making two requests on the TXO pages: one with
page, per page, and order, and then a second request with the same
params, but this time with sort added to the mix.
Because we were using a glob to match all requests to the TXO
endpoints, calling cy.wait will stop at the first match, and will not
also wait for the second request. I added a second named route to
match the second request, and we are now waiting for that one as well.
Examples of recent failed tests:
https://app.circleci.com/pipelines/github/transcom/mymove/23944/workflows/3f4e6f60-9ae3-4bb4-bf00-521ec34183dc/jobs/370649
https://app.circleci.com/pipelines/github/transcom/mymove/23954/workflows/f872e2a7-6a40-466a-9918-d7003174fb0e/jobs/370793
Resources and other potential things we can try if this doesn't work:
https://www.cypress.io/blog/2020/11/17/when-can-the-test-submit-a-form/
cypress-io/cypress#5743 (comment)
cypress-io/cypress#7306