Skip to content

Commit

Permalink
Updated grade caching so that questions with different question text …
Browse files Browse the repository at this point in the history
…still use the cached outcome.

That is, something has to change in the actual job being run to force a real regrade.
  • Loading branch information
mckeownp committed Mar 8, 2024
1 parent c333529 commit 60f5321
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions classes/jobrunner.php
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ private function run_combinator($isprecheck) {
// affect caching. For example the questionid will change each time
// the question is saved thanks to question versioning - urgh!
foreach ($this->testcases as $tc) {
// unset($tc->id); May be ok to leave in there????
unset($tc->id);
unset($tc->questionid);
}
$numtests = count($this->testcases);
Expand Down Expand Up @@ -248,7 +248,7 @@ private function run_tests_singly($isprecheck) {
// affect caching. For example the questionid will change each time
// the question is saved thanks to question versioning - urgh!
foreach ($this->testcases as $tc) {
// unset($tc->id); May be Ok to leave there?
unset($tc->id);
unset($tc->questionid);
}
$numtests = count($this->testcases);
Expand Down

0 comments on commit 60f5321

Please sign in to comment.