-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/add spatialid md #26
base: develop
Are you sure you want to change the base?
Conversation
buscandoaverroes
commented
Jun 24, 2024
- add explanatory guide (/documentation/Guide01.ipynb
- add spatial_id introductory markdown
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reviewed it.
Check it out.
@@ -1,2 +1,3 @@ | |||
**/.DS_Store | |||
.vscode/**/* | |||
**/log/**/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GitHub is warning you because the last line is missing a newline.
This absence causes an incorrect comparison.
This is not your fault, but please add a newline.
"- FitClearanceAroundExtendedSpatialID()\n", | ||
"\n", | ||
"### External Data and License Notice\n", | ||
"This guide will use geodetic coordinates from [OpenStreetMap](openstreetmap.org/copyright); please note that the data is available under the Open Database License. Please refer to the link for more information. The following code is not part of OpenStreeMap; it's provided by Trajectory under the MIT license. Please feel free to learn and contribute!\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First, the web link is incorrect and cannot be accessed.
Please fix it.
Second, OpenStreeMap
is a typo.
Please fix it.
- `x` is the Longitude Index | ||
- `y` is the Latitude Index | ||
- `vZoom` is the Vertical Zoom Level | ||
- `f` is the Altitude Index |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This identifier is z
.
Please correct it.
The same applies to the others.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you use GoNB instead of Godoc?
This document requires us to install GoNB and Jupyter Notebook, and understand what %%
means.
Is that cost less than the benefit of this document?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you use markdown instead of Godoc?
I rewrite this to GoDoc. |