Basic solver stats #2415
Merged
Basic solver stats #2415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
montyly
reviewed
Mar 29, 2021
ehennenfent
reviewed
Apr 6, 2021
manticore/core/manticore.py
Outdated
| context["time_ended"] = time_ended | ||
| context["time_elapsed"] = time_elapsed | ||
| else: | ||
| logger.info("Warning: manticore failed to run") |
There was a problem hiding this comment.
- See above re: info/warning disconnect
- "Manticore failed to run" seems a little bit aggressive. Maybe "Run start time not found in context. Was
save_run_datacalled without callingrun?"
There was a problem hiding this comment.
The log level for this was changed to warning. This error will happen if you provide manticore with incorrect binary code or bytecode. Typically, when a smart contract is not properly compiled. Right now, this is output:
2021-04-06 09:15:54,463: [13997] m.c.manticore:INFO: Generated testcase No. 0 - NO STATE RESULT (?)(0 txs)
2021-04-06 09:15:54,464: [13997] m.c.plugin:WARNING: Caught will_solve in state None, but failed to capture its initialization
2021-04-06 09:15:54,475: [13984] m.c.manticore:INFO: Results in /home/g/Data/manticore-benchmarks/mcore_mkg0pep9
Here manticore does not provide any good feedback that it failed to run beyond the "NO STATE RESULT (?)", that's why "Manticore failed to run" can be appropriated (but I'm open to suggestions).
ehennenfent
approved these changes
Apr 14, 2021
Merged
ekilmer
added a commit
that referenced
this pull request
Jul 15, 2021
* master: Install pinned version of truffle to fix CI (#2467) Use fixed owner and attacker accounts in multi_tx_analysis (#2464) Manticore 0.3.6 (#2456) Fix IntrospectionAPIPlugin Name (#2459) Portfolio of parallel solvers (#2420) Replace Quick mode with Thorough mode (#2457) Fix incorrect comparison for symbolic file wildcards (#2454) Reduce the number of calls to the SMT solver in EVM (#2411) Fixes to Unicorn emulation - start/stop/resume (#1796) Add support for multiple compilation units (#2444) Basic solver stats (#2415)
ekilmer
added a commit
that referenced
this pull request
Jul 27, 2021
* master: (35 commits) Track last_pc in StateDescriptors (#2471) Expose Result Register for Native CPU (#2470) Install pinned version of truffle to fix CI (#2467) Use fixed owner and attacker accounts in multi_tx_analysis (#2464) Manticore 0.3.6 (#2456) Fix IntrospectionAPIPlugin Name (#2459) Portfolio of parallel solvers (#2420) Replace Quick mode with Thorough mode (#2457) Fix incorrect comparison for symbolic file wildcards (#2454) Reduce the number of calls to the SMT solver in EVM (#2411) Fixes to Unicorn emulation - start/stop/resume (#1796) Add support for multiple compilation units (#2444) Basic solver stats (#2415) Fix the generation of EVM tests (#2426) Disabled EVM events in testcases by default (#2417) added proper timeouts for cvc4 and boolector (#2418) Removed use of global solver from Native Memory (#2414) Support to use boolector as the SMT solver (#2410) Update CI and suggest to use pip3 instead of pip (#2409) Expressions use keyword-only arguments for init (#2395) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This small PR includes a global dictionary that keeps tracks of when each solver is used succefully, timeouts or returns unknown. At the end, the result will be saved in a plain text file called
global.solver_stats. If the solver returned either timeout or unknown, the user will be warned about it.