Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: guest profile for XP Cloud site #22

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

pozil
Copy link
Contributor

@pozil pozil commented Nov 5, 2024

  • feat: guest profile for the XP Cloud site with the right permissions and sharing rules.
  • feat: small optimization in setup script that allows us to only call once sf org display instead of twice.

@pozil pozil requested a review from a team as a code owner November 5, 2024 23:01
@@ -0,0 +1,17 @@
<?xml version="1.0" encoding="UTF-8"?>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the sharing rules be in the metadata? Asking b/c they are listed in .forceignore, so unclear about the reason for having them.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These 4 types in .forceignore because they are tied to the profile and we can't retrieve them in the source format because of the profile:

  • profiles
  • profilePasswordPolicies
  • profileSessionSettings
  • sharingRules

This mirrors what we did with E-Bikes.

@muenzpraeger
Copy link
Contributor

muenzpraeger commented Nov 6, 2024 via email

@pozil
Copy link
Contributor Author

pozil commented Nov 6, 2024

No, .forceignore doesn't apply to this command because it's packaged metadata so it will get deployed manually when the user runs:

sf project deploy start --metadata-dir=guest-profile-metadata -w 10

The ignore file will only prevent the user from retrieving this metadata when running sf project retrieve start

@muenzpraeger muenzpraeger merged commit cb96f09 into rw/service-agents Nov 6, 2024
2 checks passed
@muenzpraeger muenzpraeger deleted the pozil/site-permissions-and-ux branch November 6, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants