Teach #from_hash to raise TypeError when argument is not a Hash #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Coles <[email protected]>
Signed-off-by: Alex Coles <[email protected]>
myabc
commented
Nov 16, 2016
| @@ -26,6 +26,7 @@ def collection_representer_class | |||
|
|
|||
| def from_hash(data, options={}, binding_builder=Binding) | |||
| data = filter_wrap(data, options) | |||
| raise TypeError, "Expected Hash, got #{data.class}." unless ::Hash === data | |||
There was a problem hiding this comment.
@apotonick could rely on duck typing here (unless data.respond_to?(:has_key?), but I think this approach is probably safer.
myabc
commented
Nov 16, 2016
| band.from_hash({"name"=>"Social Distortion"}, wrap: false).name.must_equal "Social Distortion" | ||
| band.from_hash({band: {"name"=>"Social Distortion"}}, wrap: :band).name.must_equal "Social Distortion" | ||
| band.from_hash({"name"=>"Bad Religion"}, wrap: false).name.must_equal "Bad Religion" | ||
| band.from_hash({"band"=>{"name"=>"Pennywise"}}, wrap: :band).name.must_equal "Pennywise" |
There was a problem hiding this comment.
@apotonick as long as filter_wrap_for calls #to_s on wrap (and we don't mix in AllowSymbols), this is necessary.
Signed-off-by: Alex Coles <[email protected]>
myabc
force-pushed
the
from_hash-fixes
branch
from
4f8c9e2
to
8239003
Compare
myabc
commented
Nov 16, 2016
| @@ -19,6 +19,14 @@ def items(options={}, &block) | |||
|
|
|||
| # TODO: revise lonely collection and build separate pipeline where we just use Serialize, etc. | |||
|
|
|||
| def from_hash(data, options={}, binding_builder=Binding) | |||
| data = filter_wrap(data, options) | |||
| data = [data] if ::Hash === data | |||
There was a problem hiding this comment.
@apotonick this makes #from_hash more lenient - accepting a single Hash for a collection. I'm not sure if this is desirable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@apotonick An alternative would be for
#from_hashto fail silently (i.e.data = {} unless ::Hash === data). However, I think raising aTypeErrormakes more sense in a web application context. it allows theOperationor web framework Controller to rescueTypeErrorand return a400to the client.