-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for modifying relations based on object metadata #16
Open
acannistra
wants to merge
17
commits into
master
Choose a base branch
from
tony/fixup-relations
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JesseCrocker
approved these changes
Jul 14, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looked over code, LGTM
We're not going to do this anymore. Perhaps we will merge this later on, but it's not going to be in this version. |
Putting some docs here in case we get back to this:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding activity classification to the pre-import pipeline (https://github.com/trailbehind/USFSConflation/pull/32) has revealed that we will sometimes need to ensure that new OSM objects added during conflation are also added to relations.
This PR implements the ability to include newly-created OSM objects into existing Relations. We do this by looking for a special Tag name prefix (currently
_member_of_
). These tags should contain as their Values the ID of a relation that the objects should be added to.After creating a mapping from ID -> Relation, we lookup the relations referenced in the
_member_of
Tags and add the OSM object that has that tag to the corresponding relation in the aforementioned mapping. We also keep track of the modified relations.Once all objects are processed, we output a list of modified Relation objects and create a
<modify>
tag for them in the changefile.This feature is disabled by default and can be enabled with the
--modify_relations
flag.I haven't tested this fully yet.