Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nil request body with retry #4075

Merged
merged 1 commit into from
Oct 23, 2018
Merged

Nil request body with retry #4075

merged 1 commit into from
Oct 23, 2018

Conversation

ldez
Copy link
Contributor

@ldez ldez commented Oct 18, 2018 •
edited
Loading

What does this PR do?

Nil request body with retry.

Motivation

Fixes #4013

github.com/containous/traefik/middlewares.recoverFunc(0x7fc743112078, 0xc000efa090, 0xc00114ea00)
	/go/src/github.com/containous/traefik/middlewares/recover.go:40 +0x1b7
panic(0x21d58a0, 0x4530f40)
	/usr/local/go/src/runtime/panic.go:513 +0x1b9
github.com/containous/traefik/middlewares.(*Retry).ServeHTTP(0xc000cbf860, 0x7fc743112168, 0xc000efa0c0, 0xc00114f500)
	/go/src/github.com/containous/traefik/middlewares/retry.go:38 +0x5e8
github.com/containous/traefik/middlewares/tracing.(*HTTPHandlerWrapper).ServeHTTP(0xc000cbf890, 0x7fc743112168, 0xc000efa0c0, 0xc00114f500)
	/go/src/github.com/containous/traefik/middlewares/tracing/wrapper.go:63 +0xd5
github.com/containous/traefik/middlewares/errorpages.(*Handler).ServeHTTP(0xc0003898f0, 0x7fc743112078, 0xc000efa0a8, 0xc00114ef00, 0xc00130d100)
	/go/src/github.com/containous/traefik/middlewares/errorpages/error_pages.go:102 +0x867
github.com/containous/traefik/vendor/github.com/urfave/negroni.middleware.ServeHTTP(0x2935200, 0xc0003898f0, 0xc0010e0960, 0x7fc743112078, 0xc000efa0a8, 0xc00114ef00)
	/go/src/github.com/containous/traefik/vendor/github.com/urfave/negroni/negroni.go:33 +0x9c
github.com/containous/traefik/vendor/github.com/urfave/negroni.(*Negroni).ServeHTTP(0xc000cbff20, 0x7fc743112118, 0xc000920d00, 0xc00114ef00)
	/go/src/github.com/containous/traefik/vendor/github.com/urfave/negroni/negroni.go:81 +0xee
github.com/containous/traefik/vendor/github.com/containous/mux.(*Router).ServeHTTP(0xc0007c8300, 0x7fc743112118, 0xc000920d00, 0xc00114ef00)
	/go/src/github.com/containous/traefik/vendor/github.com/containous/mux/mux.go:133 +0xf1
github.com/containous/traefik/middlewares.(*HandlerSwitcher).ServeHTTP(0xc00000c008, 0x7fc743112118, 0xc000920d00, 0xc00114ed00)
	/go/src/github.com/containous/traefik/middlewares/handlerSwitcher.go:24 +0x6f
github.com/containous/traefik/vendor/github.com/urfave/negroni.Wrap.func1(0x7fc743112118, 0xc000920d00, 0xc00114ed00, 0xc00130d0e0)
	/go/src/github.com/containous/traefik/vendor/github.com/urfave/negroni/negroni.go:41 +0x4d
github.com/containous/traefik/vendor/github.com/urfave/negroni.HandlerFunc.ServeHTTP(0xc000962600, 0x7fc743112118, 0xc000920d00, 0xc00114ed00, 0xc00130d0e0)
	/go/src/github.com/containous/traefik/vendor/github.com/urfave/negroni/negroni.go:24 +0x4e
github.com/containous/traefik/vendor/github.com/urfave/negroni.middleware.ServeHTTP(0x2939e00, 0xc000962600, 0xc000962700, 0x7fc743112118, 0xc000920d00, 0xc00114ed00)
	/go/src/github.com/containous/traefik/vendor/github.com/urfave/negroni/negroni.go:33 +0x9c
github.com/containous/traefik/vendor/github.com/urfave/negroni.middleware.ServeHTTP-fm(0x7fc743112118, 0xc000920d00, 0xc00114ed00)
	/go/src/github.com/containous/traefik/vendor/github.com/urfave/negroni/negroni.go:33

More

  • [-] Added/updated tests
  • [-] Added/updated documentation

@traefiker traefiker added this to the 1.7 milestone Oct 18, 2018
mmatur
mmatur approved these changes Oct 19, 2018
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

juliens
juliens approved these changes Oct 22, 2018
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

juliens
juliens approved these changes Oct 22, 2018
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dduportal
dduportal approved these changes Oct 23, 2018
View reviewed changes
Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 3f044c4 into traefik:v1.7 Oct 23, 2018
@traefiker traefiker mentioned this pull request Oct 23, 2018
Closed
@ldez ldez deleted the fix/retry branch October 23, 2018 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmatur mmatur mmatur approved these changes

@dduportal dduportal dduportal approved these changes

@juliens juliens juliens approved these changes

Assignees
No one assigned
Labels
area/authentication area/middleware kind/bug/fix a bug fix size/S
Projects
None yet
Milestone
1.7
Development

Successfully merging this pull request may close these issues.
5 participants
@ldez @juliens @dduportal @mmatur @traefiker