Cleanup Connection headers before passing the middleware chain #11077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinpollet
added
status/2-needs-review
kind/bug/fix
lbenguigui
reviewed
Sep 13, 2024
rtribotte
force-pushed
the
connection
branch
from
531e7c6
to
26a5be7
Compare
|
Is this the relevant PR that fixes GHSA-62c8-mh53-4cqv? Or are the additional ones? We want to backport the fix to a version of Traefik, that does not need Go 1.23, as we don't have it in the stable branch of Nixpkgs yet. |
|
Hello @Scrumplex, Yes, indeed, this is the PR that fixes GHSA-62c8-mh53-4cqv, and there are no additional ones strictly in this regard. |
Scrumplex
added a commit
to Scrumplex/traefik
that referenced
this pull request
Sep 24, 2024
…ain" to v3.1.2 See traefik@5841441 See traefik#11077 Fixes GHSA-62c8-mh53-4cqv for v3.1.2 Signed-off-by: Sefa Eyeoglu <[email protected]>
13 tasks
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This pull request cleans the Connection headers before passing the middleware chain. When a connection header needs to pass through the middleware chain, the
forwardedHeaders.connectionoption has to be used.More
Additional Notes
Co-authored-by: Romain [email protected]