Ensure defaultGeneratedCert.main as Subject's CN #10581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lamatte
force-pushed
the
defaultGeneratedCertCommonName
branch
2 times, most recently
from
32850ed
to
954d995
Compare
Lamatte
changed the title
defaultGenaratedCert CNdefaultGeneratedCert CN
Lamatte
force-pushed
the
defaultGeneratedCertCommonName
branch
2 times, most recently
from
7b18c92
to
82231ef
Compare
Lamatte
changed the title
defaultGeneratedCert CN
|
Hello @Lamatte, Thank you for your contribution, and sorry for the delay. |
|
I'm closing and reopening the PR to launch the CI. |
rtribotte
reviewed
Sep 17, 2024
Lamatte
force-pushed
the
defaultGeneratedCertCommonName
branch
from
bd40bd8
to
77490f4
Compare
kevinpollet
changed the title
Lamatte
force-pushed
the
defaultGeneratedCertCommonName
branch
4 times, most recently
from
1f9d09e
to
174839c
Compare
rtribotte
requested changes
Sep 27, 2024
There was a problem hiding this comment.
Thanks @Lamatte for the latest changes.
I think we don't care using the sortedDomains in place of domains after the domainKey has been generated, and it is preferable to delimitate the usage scope of the sortedDomains to the key generation.
Lamatte
force-pushed
the
defaultGeneratedCertCommonName
branch
from
174839c
to
07d8673
Compare
traefiker
force-pushed
the
defaultGeneratedCertCommonName
branch
from
07d8673
to
c7b01d6
Compare
|
Thank you for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR aims at fixing the issue #10580, by removing the sort of domain names that makes it impossible to specify the Common Name of an Acme certificate.
I can't see why a sort would be necessary here, and I don't think removing it may impact something else.
Motivation
I'm willing to use Acme, and I have a strong requirement with the CN used within the certificate.
I cannot depend on alphabetical sort to make sure which domain will be the "main" one.
More
Additional Notes
N/A