Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow defining startupProbe #956

Merged
merged 3 commits into from
Nov 6, 2023

Conversation

demolitionmode
Copy link
Contributor

What does this PR do?

Allows users to set a startupProbe. By not defining subkeys, we can allow users to use any type of check mechanism that suits their requirement.

Motivation

Fixes #951

More

  • Yes, I updated the tests accordingly
  • Yes, I ran make test and all the tests passed

Copy link
Contributor

@darkweaver87 darkweaver87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

traefik/values.yaml Outdated Show resolved Hide resolved
@demolitionmode
Copy link
Contributor Author

Thanks for the corrections @mloiseleur, these have been applied and re-tested

Copy link
Contributor

@mloiseleur mloiseleur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR.
LGTM

@traefiker traefiker merged commit f061628 into traefik:master Nov 6, 2023
1 check passed
@demolitionmode demolitionmode deleted the feat-startupprobe branch November 6, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow users to set a startupProbe
4 participants