CRD: remove 'status:' key from generated configs #570
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CRDs in this Helm chart all follow the form:
kind: CustomResourceDefinition
metadata:
# ...
spec:
# ...
status:
acceptedNames:
kind: ""
plural: ""
conditions: []
storedVersions: []
The problem with the `status:` key is that it is usually
runtime-populated, for example by a controller.
In the case of a cluster managed by Anthos Config Management, it fails
to apply the Helm-generated Traefik configs with the error:
KNV1045: Configs with "status" specified are not allowed.
To fix, either remove the config or remove the "status" field in the config.
For more information, see https://g.co/cloud/acm-errors#knv1045
If you remove the `status:` key from the CRDs, this now applies cleanly to an
Anthos-managed cluster.
|
Hello @jeremyvisser, Thanks for your contribution, The CRDs are generated by Traefik, which means that if something is wrong with this generation an issue should be opened in the Traefik project, to avoid diverging CRD definitions. After digging a bit more on the subject, it seems that the issue is a bug of the controller-gen project (used to generate the CRDs), see kubernetes-sigs/controller-tools#456 According to this, we will decline this pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CRDs in this Helm chart all follow the form:
The problem with the
status:key is that it is usuallyruntime-populated, for example by a controller.
In the case of a cluster managed by Anthos Config Management, it fails
to apply the Helm-generated Traefik configs with the error:
If you remove the
status:key from the CRDs, this now applies cleanly to anAnthos-managed cluster.
More
Additional Notes
This does not really affect using
helm install, but it does affect a situation where youhelm templateinto a config-managed directory which is then pushed to the cluster using a separate mechanism (e.g. Anthos).