Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(renovate): add regex manager for VALUES.md #1237

Merged
merged 2 commits into from
Oct 29, 2024
Merged

chore(renovate): add regex manager for VALUES.md #1237

merged 2 commits into from
Oct 29, 2024

Conversation

logica0419
Copy link
Contributor

@logica0419 logica0419 commented Oct 29, 2024 •
edited
Loading

What does this PR do?

Added renovate regex manager to update VALUES.md

Motivation

#1235 (comment)

More

  • Yes, I updated the tests accordingly
  • Yes, I updated the schema accordingly
  • Yes, I ran make test and all the tests passed

@logica0419 logica0419 mentioned this pull request Oct 29, 2024
Merged
1 task
@mloiseleur
Copy link
Contributor

@logica0419 Thanks.
Would you please also add grouping so this regex is done in the same PR where the docker image is updated ?

@logica0419
Copy link
Contributor Author

logica0419 commented Oct 29, 2024 •
edited
Loading

I guess the updates from the same datasource are automatically grouped.
ref: https://github.com/logica0419/traefik-helm-chart/pull/2 (I experimented in my fork repository)

Do I get what you mean correctly?

@mloiseleur mloiseleur changed the title Add regex manager for VALUES.md chore(renovate): add regex manager for VALUES.md Oct 29, 2024
darkweaver87
darkweaver87 approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@darkweaver87 darkweaver87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks :-)

@traefiker traefiker merged commit 626469d into traefik:master Oct 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mloiseleur mloiseleur mloiseleur approved these changes

@darkweaver87 darkweaver87 darkweaver87 approved these changes

Assignees
No one assigned
Labels
area/infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@logica0419 @mloiseleur @darkweaver87 @traefiker