-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider browserify field #8
Conversation
Note that I remove the Also see my comment on this thread: facebook/react-native#2208 for more compatibility fixes. |
@vespakoen lgtm, maybe just squash the commits. I was thinking actually that we'd start using the |
Will do! hang in there... |
73b9c9f
to
beb4d6e
Compare
Updated and squashed, looks good? |
yep, but let's leave both "react-native" and "browser", so it works for older react-native versions |
Sounds like a good idea, just a sec |
beb4d6e
to
68cc7cf
Compare
Like that? |
@@ -237,7 +237,8 @@ function fixPackageJSON (modules, file, overwrite) { | |||
}) | |||
|
|||
if (!deepEqual(orgBrowser, depBrowser)) { | |||
pkgJson.browser = depBrowser |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
almost, just add back pkgJson.browser = depBrowser
, to have both browser
and react-native
Edit:
i mean pkgJson.browser = pkgJson['react-native'] = depBrowser
and could you check that it actually works? Sometimes these improvements piss react-packager off
Ahh good catch! Will update, test and report back |
68cc7cf
to
f48666c
Compare
Confirmed & works! ...
"browser": {
"crypto": "react-native-crypto",
"http": "react-native-http",
"querystring": "querystring-es3",
"_stream_transform": "readable-stream/transform",
"_stream_readable": "readable-stream/readable",
"_stream_writable": "readable-stream/writable",
"_stream_duplex": "readable-stream/duplex",
"_stream_passthrough": "readable-stream/passthrough",
"stream": "stream-browserify"
},
"react-native": {
"crypto": "react-native-crypto",
"http": "react-native-http",
"querystring": "querystring-es3",
"_stream_transform": "readable-stream/transform",
"_stream_readable": "readable-stream/readable",
"_stream_writable": "readable-stream/writable",
"_stream_duplex": "readable-stream/duplex",
"_stream_passthrough": "readable-stream/passthrough",
"stream": "stream-browserify"
},
... |
Pull request for issue https://github.com/mvayngrib/rn-nodeify/issues/7