Fix breaking change w/ Gradle dependencies #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a breaking API change with the Android Gradle plugin, which was deprecated as of version 3.0.0 and later made obsolete. When adding Gradle dependencies, the `compile` command has been removed and replaced with `implementation`/`api`. More information: https://docs.gradle.org/5.4.1/userguide/java_library_plugin.html#sec:java_library_separation https://developer.android.com/studio/build/dependencies?utm_source=android-studio#dependency_configurations
mvayngrib
approved these changes
Aug 1, 2019
|
@christophermark thanks! |
DomiR
added a commit
to DomiR/react-native-udp
that referenced
this pull request
Nov 22, 2019
* tradle-master: Update react-native-udp.podspec Use address instead of host name feat(socket-lib): udpate GCDAsyncUdpSocket Added handling of GCDAsyncUdpSocket's socketDidClose callback in order to bubble notification that the socket has been closed Fix breaking change w/ Gradle dependencies (tradle#88) 2.6.1 add .git to .npmignore 2.6.0 fix max MTU (tradle#84) 2.5.2 Update react-native-udp.podspec (tradle#83)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intent
This fixes a breaking API change with the Android Gradle plugin, which was deprecated as of version 3.0.0 and later made obsolete.
Changes
When adding Gradle dependencies, the
compilecommand has been removed and replaced withimplementation/api.More information