fix(Android): Catch all exceptions and redirect them to JS #202
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to my improvement: #197, if you now try to send a packet to a closed channel, you get a
RejectedExecutionException
exception.As you can see in the changed file, the send method only catches specific exceptions, and not this
RejectedExecutionException
. This actually causes an app to crash as this is unhandled.But since this is a React Native library; it's better to catch all exceptions and pass them along to React Native. There, in your js/ts code, apps can try catch this and recover from this case.
How to reproduce?