fix: Remove AsyncTask in the send function (it's deprecated) #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d also cleanup pending send tasks
|
This fix should solve #196. |
Rapsssito
changed the title
|
@eliaslecomte, thanks for the PR! LGTM! |
github-actions bot
pushed a commit
that referenced
this pull request
Feb 22, 2022
## [4.1.4](v4.1.3...v4.1.4) (2022-02-22) ### Bug Fixes * Remove AsyncTask in the send function (it's deprecated) ([#197](#197)) ([179a948](179a948))
|
🎉 This PR is included in version 4.1.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were seeing an issue in Sentry due to the use of AsyncTask in the send packet function:
It's not occurring a lot, but enough to fix :-). The bug is hard to reproduce, we assume it's due to the Activity being paused, or the app relaunched. The AsyncTask is getting executed but the socket is no more.
Given that https://developer.android.com/reference/android/os/AsyncTask is deprecated, I rewrote it.
We are currently testing these change in production.