Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update min requirements #745

Closed
3 tasks done
timocov opened this issue May 21, 2021 · 5 comments
Closed
3 tasks done

Update min requirements #745

timocov opened this issue May 21, 2021 · 5 comments
Assignees
@timocov
Labels
breaking change Changes the API in a non backwards compatible way. enhancement Feature requests, and general improvements. infrastructure Infrastructure surrounding the development of the library (CI, tests, scripts).
Milestone
4.0

Comments

@timocov
Copy link
Contributor

timocov commented May 21, 2021 •
edited by Nipheris
Loading

@timocov timocov added enhancement Feature requests, and general improvements. breaking change Changes the API in a non backwards compatible way. infrastructure Infrastructure surrounding the development of the library (CI, tests, scripts). labels May 21, 2021
@timocov timocov added this to the 4.0 milestone May 21, 2021
@h0wXD
Copy link

h0wXD commented May 30, 2021

With this you may want to add npm install --legacy-peer-deps, so deprecated packages can be installed in v14+, else people will run into errors:

lightweight-charts>npm i
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving: [email protected]
npm ERR! Found: [email protected]
npm ERR! node_modules/tslint
npm ERR!   dev tslint@"6.1.3" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer tslint@"^5.0.0" from [email protected]
npm ERR! node_modules/tslint-eslint-rules
npm ERR!   dev tslint-eslint-rules@"~5.4.0" from the root project

@timocov
Copy link
Contributor Author

timocov commented Jun 1, 2021

With this you may want to add npm install --legacy-peer-deps, so deprecated packages can be installed in v14+, else people will run into errors:

@h0wXD It looks like support for npm@7, not for nodejs v14 (by default nodejs v14 includes npm@6 which works fine at the moment - Latest LTS Version: 14.17.0 (includes npm 6.14.13) from https://nodejs.org/en/download/).

@EugeneMeles
Copy link

EugeneMeles commented Aug 17, 2021 •
edited
Loading 

npm ERR! Could not resolve dependency:
npm ERR! peer tslint@"^5.0.0" from [email protected]
npm ERR! node_modules/tslint-eslint-rules
npm ERR!   dev tslint-eslint-rules@"~5.4.0" from the root project

Yeap, problem with dependency in tslint-eslint-rules for tslint
Issue about this open from 2020 😢

@timocov timocov self-assigned this Nov 11, 2021
@timocov timocov mentioned this issue Feb 18, 2022
Merged
3 tasks
timocov added a commit that referenced this issue Mar 3, 2022
@timocov
Changed target of TypeScript compilation to es2016
586512e 
Partially addressed to #745
@timocov timocov mentioned this issue Mar 3, 2022
Merged
3 tasks
@timocov
Copy link
Contributor Author

timocov commented Feb 7, 2023

@SlicedSilver looks like it is finished already and can be closed?

@SlicedSilver
Copy link
Contributor

@SlicedSilver looks like it is finished already and can be closed?
Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@timocov timocov

Labels
breaking change Changes the API in a non backwards compatible way. enhancement Feature requests, and general improvements. infrastructure Infrastructure surrounding the development of the library (CI, tests, scripts).
Projects
None yet
Milestone
4.0
Development

No branches or pull requests
4 participants
@timocov @SlicedSilver @h0wXD @EugeneMeles