Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GL-382: Exemption list UI #710

Merged
merged 10 commits into from
Jun 12, 2024
Merged

GL-382: Exemption list UI #710

merged 10 commits into from
Jun 12, 2024

Conversation

rasikasri
Copy link
Contributor

Jira link

HOTT-

What?

I have added/removed/altered:

  • Added Admin UI screen to list the exemptions

Why?

I am doing this because:

  • Admin user should be able to manage exemption

jebw
jebw previously approved these changes May 30, 2024
View reviewed changes
Copy link
Contributor

@jebw jebw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, theres a white space fix and I'm not sure we want the user caring about what the id of the exemption is - they'll be more focused on what the code is - maybe one to check with Gabriel though?

app/controllers/green_lanes/exemptions_controller.rb Show resolved Hide resolved
app/views/green_lanes/exemptions/index.html.erb Outdated Show resolved Hide resolved
alexdesi
alexdesi approved these changes Jun 12, 2024
View reviewed changes
Copy link
Contributor

@alexdesi alexdesi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅

@rasikasri rasikasri merged commit 7b34d8f into main Jun 12, 2024
13 of 14 checks passed
@rasikasri rasikasri deleted the GL-382-exemption-list-ui branch June 12, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexdesi alexdesi alexdesi approved these changes

@jebw jebw jebw left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rasikasri @jebw @alexdesi