Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GL-106: Add Admin screen to list out all category assessments #671

Merged
merged 5 commits into from
Apr 8, 2024

Conversation

rasikasri
Copy link
Contributor

Jira link

GL-106

What?

I have added/removed/altered:

  • Added an admin screen to list all category assessments

Why?

I am doing this because:

  • We can see what is in the category assessments table and manage them

Have you? (optional)

  • Reviewed view changes with stake holders
  • Validated mobile responsive behaviour of view changes

jebw
jebw previously approved these changes Mar 25, 2024
Copy link
Contributor

@jebw jebw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@jebw jebw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - addition to exceptions may not be redundant but wont cause harm either

@@ -6,4 +6,5 @@
'ActionController::UnknownFormat' => :not_found,
'AbstractController::ActionNotFound' => :not_found,
'URI::InvalidURIError' => :not_found,
'ActionController::RoutingError' => :not_found,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is in the default rails list isn't it? So shouldn't be needed?

@rasikasri rasikasri merged commit 1f13e07 into main Apr 8, 2024
16 checks passed
@rasikasri rasikasri deleted the GL-106 branch April 8, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants