HOTT-4301 set NODE_OPTIONS for webpack compilation #584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The NODE_OPTIONS env var is necessary to make webpack 4 (needed by webpacker) work in OpenSSL 3 Setting it via `.env.development` doesn't work because because that is only loaded during application initialisation which doesn't happen during `rails webpacker:compile` Instead I've inserted it into the `bin/webpack` binstub used by webpacker
maverickvi
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira link
HOTT-4301
What?
I have added/removed/altered:
Why?
I am doing this because:
.envfiles works for specs but not for dynamic compilation viarails sor viarails webpacker:compile- because the env files are loaded during app initialization and the app is seems not to be initialized for the webpacker processDeployment risks (optional)
bin/webpackbinary