Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not export missing hits, avoid extra material effect application in backward-fit #376

Merged
merged 2 commits into from
Oct 27, 2021

Conversation

osschar
Copy link
Collaborator

@osschar osschar commented Oct 26, 2021

  • For clone-engine keep candidate state at last valid hit.
  • Add option to export candidates without missing hit information, use it for CMSSW runOneIteration().
  • In backward fit avoid re-application of material effects when a track does not have a valid hit on current layer.

MTV with PR-372 as ref: http://xrd-cache-1.t2.ucsd.edu/matevz/PKF/no_missing_hits_und_no_mateff_bkfit.vs.PR-372
MTV with CKF as ref: http://xrd-cache-1.t2.ucsd.edu/matevz/PKF/no_missing_hits_und_no_mateff_bkfit.vs.CKF

osschar and others added 2 commits October 26, 2021 10:03
Add option to export candidates without missing hit information, use
it for CMSSW runOneIteration.

In backward fit avoid re-application of material effects when a track
does not have a valid hit on current layer.
@mmasciov
Copy link
Collaborator

After fixing a minor conflict, merging this PR.

@mmasciov mmasciov merged commit 15d9086 into devel Oct 27, 2021
@osschar osschar deleted the no_missing_hits_und_no_mateff_bkfit branch December 13, 2021 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants