-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
write/read beam spot in a standalone setup #364
Conversation
@slava77 will be testing it in the coming hours, and will post here a validation. |
I have done couple of tests, printing beamspot information in "quality_filter_layers" from standalone validation (using 11834.0_TTbar_14TeV+2021/AVE_50_BX01_25ns/memoryFile.fv6.default.211007-652f30c.bin, after PR #364) and from within CMSSW (after PR #364 and PR trackreco/cmssw#54), getting different answers: [In mkFit/MkStdSeqs.cc:
--> Beamspot information does not appear to be correctly written and/or read in standalone setup. |
@mmasciov |
Strange ... sorry about this :( |
Just for history: this seems not sufficient to fix the issue in the standalone setup. |
After looking closer on the writer side, there is one bug on the trackingNtuple side: bsp_z is buggy and contains bs.x. This, however doesn't solve the problem with the bin file read/write. .. not sure I want to dig deeper now, perhaps we can save this by hardcoding the Run3 MC default in the default construction of the BeamSpot? |
a7daaeb
to
46f7bfa
Compare
Based on one event check, the writing part is correct. There is apparently a shift of 2 words during reading in a setup where the CMSSW tracks are skipped. |
46f7bfa
to
c6b7c67
Compare
@slava77 Thanks! I believe this is therefore ready to be merged. |
to match this PR final commit, I made a limited update to the .bin files: memoryFile.fv6.default.211008-c6b7c67.bin
These totals seemed to be good enough for all of the validation purposes and even most of the throughput benchmarks. |
The file version is updated to v6.
The read/write code should be backward compatible with the older versions 4 (before the masks) and 5.
I made a test file
11834.0_TTbar_14TeV+2021/AVE_50_BX01_25ns/memoryFile.fv6.default.211007-652f30c.bin
but I did not try to run the standalone validation on this yet.