Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix backward params in JSON to same values as for forward search #354

Merged
merged 1 commit into from
Sep 8, 2021

Conversation

mmasciov
Copy link
Collaborator

@mmasciov mmasciov commented Sep 8, 2021

No change for iterations without backward search:
http://uaf-10.t2.ucsd.edu/~mmasciov/MkFit_devs/SVA_newJSON_iter4/

For iterations with backward search, re-establishing intended parameters causes minor differences in performance:
http://uaf-10.t2.ucsd.edu/~mmasciov/MkFit_devs/SVA_newJSON_iter9/

However, given that such iterations are not included by default in CMSSW and that differences are anyways minor, I suggest we merge this PR and use the originally intended parameters.

@mmasciov
Copy link
Collaborator Author

mmasciov commented Sep 8, 2021

Diff in corresponding JSONs only affect bkw parameters. For new JSONs, they match fwd ones, except for conditions on max number of holes, which are still relaxed.
mkFit > diff -y --suppress-common-lines oldJSON/mkfit-phase1-pixelLessStep.json newJSON/mkfit-phase1-pixelLessStep.json
"nlayers_per_seed": 4, | "nlayers_per_seed": 3,
"maxCandsPerSeed": 5, | "maxCandsPerSeed": 2,
"c_drmax_bh": 0.009999999776482582, | "c_drmax_bh": 0.13500000536441803,
"c_dzmax_bh": 0.004999999888241291, | "c_dzmax_bh": 0.13500000536441803,
"c_drmax_eh": 0.009999999776482582, | "c_drmax_eh": 0.13500000536441803,
"c_dzmax_eh": 0.009999999776482582, | "c_dzmax_eh": 0.13500000536441803,
"c_drmax_bl": 0.009999999776482582, | "c_drmax_bl": 0.13500000536441803,
"c_dzmax_bl": 0.004999999888241291, | "c_dzmax_bl": 0.13500000536441803,
"c_drmax_el": 0.014999999664723873, | "c_drmax_el": 0.13500000536441803,
"c_dzmax_el": 0.014999999664723873, | "c_dzmax_el": 0.13500000536441803,
"fracSharedHits": 0.5, | "fracSharedHits": 0.1899999976158142,

@osschar osschar merged commit 55bd96a into devel Sep 8, 2021
@osschar osschar deleted the updateJSONBkwSearch branch December 14, 2021 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants