refactor(openai): rename functions to tools #1504
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achang97
commented
Jul 9, 2024
| @@ -138,10 +183,6 @@ async def test_open_ai_function_calls_tools_streaming( | |||
| open_ai_span.attributes[f"{SpanAttributes.LLM_COMPLETIONS}.0.tool_calls.0.id"], | |||
| str, | |||
| ) | |||
| assert ( | |||
There was a problem hiding this comment.
I dropped these checks because these tests are checking the LLM_COMPLETIONS output and the functionality for checking LLM_TOOLS shouldn't differ
|
This introduces a breaking change, and given that we have another breaking change coming soon which is the approved semantic convention I don't think we should merge this as of now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(instrumentation): ...orfix(instrumentation): ....