Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

images source #2558

Merged
merged 4 commits into from
Nov 28, 2024
Merged

images source #2558

merged 4 commits into from
Nov 28, 2024

Conversation

wangjiawen2013
Copy link
Contributor

Pull Request Template

Checklist

  • Confirmed that run-checks all script has been executed.
  • Made sure the book is up to date with changes in this PR.

Related Issues/PRs

Provide links to relevant issues and dependent PRs.

Changes

Summarize the problem being addressed and your solution.

Testing

Describe how these changes have been tested.

@wangjiawen2013
Copy link
Contributor Author

wangjiawen2013 commented Nov 28, 2024

After adding image source filed, we can get the result like this:
image

Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.38%. Comparing base (b4cef57) to head (aa01b87).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2558      +/-   ##
==========================================
+ Coverage   82.31%   82.38%   +0.06%     
==========================================
  Files         831      825       -6     
  Lines      105703   105659      -44     
==========================================
+ Hits        87013    87042      +29     
+ Misses      18690    18617      -73     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@laggui laggui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Just a small formatting issue, I'll fix it and merge 👍

Closes #2516

@laggui laggui merged commit 9d073e7 into tracel-ai:main Nov 28, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants