Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add QTensorOps docs + refactor tests to simplify inputs #2557

Merged
merged 5 commits into from
Nov 27, 2024

Conversation

laggui
Copy link
Member

@laggui laggui commented Nov 27, 2024

Checklist

  • Confirmed that run-checks all script has been executed.

Changes

  • Refactored qtensor ops tests w/ QTensor helper struct
    • Previously defined inputs was clunky, error prone and difficult to understand. Now anyone can more easily add tests for operations using floating point values. QTensor methods will automatically quantize the inputs.
  • Added missing q_split tests
  • Added QTensorOps docs to burn contrib book
  • Fixed zero scale edge cases everywhere

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 99.52229% with 3 lines in your changes missing coverage. Please review.

Project coverage is 82.31%. Comparing base (1e511b5) to head (47fb7e4).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
...es/burn-tensor/src/tests/quantization/ops/chunk.rs 76.92% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2557      +/-   ##
==========================================
- Coverage   82.50%   82.31%   -0.19%     
==========================================
  Files         828      831       +3     
  Lines      107040   105703    -1337     
==========================================
- Hits        88314    87013    -1301     
+ Misses      18726    18690      -36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@louisfd louisfd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Much cleaner :)

@nathanielsimard nathanielsimard merged commit b4cef57 into main Nov 27, 2024
11 checks passed
@nathanielsimard nathanielsimard deleted the docs/qtensor branch November 27, 2024 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants