Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infer convolution kernel shape from weight #2544

Merged
merged 2 commits into from
Nov 28, 2024
Merged

Conversation

laggui
Copy link
Member

@laggui laggui commented Nov 26, 2024

Checklist

  • Confirmed that run-checks all script has been executed.

Related Issues/PRs

Fixes #2430

Changes

Infer convolution kernel shape from weights (in line with ONNX spec)

@laggui laggui requested a review from antimora November 26, 2024 20:41
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 75.75758% with 8 lines in your changes missing coverage. Please review.

Project coverage is 82.50%. Comparing base (1e511b5) to head (15955ca).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
crates/onnx-ir/src/node_remap.rs 50.00% 4 Missing ⚠️
crates/burn-import/src/onnx/op_configuration.rs 66.66% 3 Missing ⚠️
crates/onnx-ir/src/util.rs 93.75% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2544      +/-   ##
==========================================
- Coverage   82.50%   82.50%   -0.01%     
==========================================
  Files         828      828              
  Lines      107040   107073      +33     
==========================================
+ Hits        88314    88336      +22     
- Misses      18726    18737      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@nathanielsimard nathanielsimard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@laggui laggui merged commit ac39916 into main Nov 28, 2024
11 checks passed
@laggui laggui deleted the fix/onnx/infer-conv-shape branch November 28, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conv kernel shapes not inferred
2 participants