型をいい感じにして空配列を渡したときにエラーにならないように #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ras0q
approved these changes
May 5, 2024
Comment on lines
10
to
+11
| const query = _query.toLowerCase() | ||
| // valueがstringなので、item[key]もstringなはず | ||
| return list.filter(item => | ||
| (item[key] as string).toLowerCase().includes(query) | ||
| ) | ||
| return list.filter(item => item[key].toLowerCase().includes(query)) |
There was a problem hiding this comment.
imo: query定義せずにワンライナーで書くほうが好み(可読性変わらなそう)
There was a problem hiding this comment.
listの要素数分だけtoLowerCaseするのがなんか嫌なのでこうしてます(多分どっちでもあんまり変わらない)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #227
typescriptに敗北したのでany使ってます
open-apiの型定義がinterfaceじゃなくてtype aliasだったらエラーにならないらしいけどなんでinterfaceだとエラーになるのかよく分かってない
多分これ: microsoft/TypeScript#50087