Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

macaraon-css を UnoCSS に置き換える #951

Merged
merged 62 commits into from
Nov 6, 2024
Merged

macaraon-css を UnoCSS に置き換える #951

merged 62 commits into from
Nov 6, 2024

Conversation

cp-20
Copy link
Contributor

@cp-20 cp-20 commented Aug 18, 2024 •
edited
Loading

なぜやるか

close #949

やったこと

  • macaron-css で書かれていた style / styled components を UnoCSS で全て書き換えた
    • 一部 css module 含む
  • Material Symbols のアイコンをフォントから UnoCSS のプラグインを経由して使うように

やらなかったこと

  • 共通スタイルをまとめる
    • (詳しく調べてはないが) いくつかの箇所で共通のスタイルが使われているので、これをまとめることでより簡潔にスタイルを記述できるようになりそう

資料

@github-actions GitHub Actions
Copy link

Preview (prod backend + PR dashboard) → https://951.ns-preview.trapti.tech/

@motoki317 motoki317 linked an issue Aug 28, 2024 that may be closed by this pull request
macaron-css/solid 1.5.2 #910
Closed
eyemono-moe
eyemono-moe reviewed Nov 1, 2024
View reviewed changes
Copy link
Contributor

@eyemono-moe eyemono-moe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

また何点かコメントさせていただきました(1回のレビューで気づけずすみません🙇)
多分これが最後のはず...!

dashboard/src/components/UI/UserMenuButton.tsx Outdated Show resolved Hide resolved
dashboard/src/components/templates/app/AppDeployInfo.tsx Outdated Show resolved Hide resolved
dashboard/src/components/templates/build/BuildRow.tsx Show resolved Hide resolved
dashboard/src/features/application/components/form/RepositoryStep.tsx Outdated Show resolved Hide resolved
dashboard/src/features/application/components/form/website/WebsiteFieldGroup.tsx Outdated Show resolved Hide resolved
dashboard/src/features/application/components/form/website/WebsiteFieldGroup.tsx Outdated Show resolved Hide resolved
dashboard/src/features/application/components/form/EnvVarConfigForm.tsx Outdated Show resolved Hide resolved
@cp-20 cp-20 mentioned this pull request Nov 2, 2024
Closed
eyemono-moe
eyemono-moe approved these changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@eyemono-moe eyemono-moe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMです!
修正本当にありがとうございました 🙇

一か所だけコメントしましたが、正直無視しちゃっていいです(直した場合再度review依頼せずにもうmergeしちゃってokです)

dashboard/src/components/UI/Button.tsx Outdated Show resolved Hide resolved
@cp-20 cp-20 merged commit 96cb7c2 into main Nov 6, 2024
18 checks passed
@cp-20 cp-20 deleted the feat/replace-macaron-css-with-uno-css branch November 6, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyemono-moe eyemono-moe eyemono-moe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

macaron-css から UnoCSS に書き換える macaron-css/solid 1.5.2
2 participants
@cp-20 @eyemono-moe