Skip to content

Commit

Permalink
fix: Move gRPC dependencies to an extra (feast-dev#3900)
Browse files Browse the repository at this point in the history
  • Loading branch information
cburroughs authored and tqtensor committed Mar 11, 2024
1 parent 989b268 commit 4200b9d
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ set -e

# feast root directory is expected to be mounted (eg, by docker compose)
cd /mnt/feast
pip install -e '.[redis]'
pip install -e '.[grpcio,redis]'

cd /app
python materialize.py
feast serve_transformations --port 8080
feast serve_transformations --port 8080
15 changes: 10 additions & 5 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -44,10 +44,6 @@
"click>=7.0.0,<9.0.0",
"colorama>=0.3.9,<1",
"dill~=0.3.0",
"grpcio>=1.56.2,<2",
"grpcio-tools>=1.56.2,<2",
"grpcio-reflection>=1.56.2,<2",
"grpcio-health-checking>=1.56.2,<2",
"mypy-protobuf==3.1",
"Jinja2>=2,<4",
"jsonschema",
Expand Down Expand Up @@ -143,7 +139,14 @@

IBIS_REQUIRED = [
"ibis-framework",
"ibis-substrait"
"ibis-substrait",
]

GRPCIO_REQUIRED = [
"grpcio>=1.56.2,<2",
"grpcio-tools>=1.56.2,<2",
"grpcio-reflection>=1.56.2,<2",
"grpcio-health-checking>=1.56.2,<2",
]

DUCKDB_REQUIRED = [
Expand Down Expand Up @@ -209,6 +212,7 @@
+ ROCKSET_REQUIRED
+ HAZELCAST_REQUIRED
+ IBIS_REQUIRED
+ GRPCIO_REQUIRED
)


Expand Down Expand Up @@ -375,6 +379,7 @@ def run(self):
"docs": DOCS_REQUIRED,
"cassandra": CASSANDRA_REQUIRED,
"hazelcast": HAZELCAST_REQUIRED,
"grpcio": GRPCIO_REQUIRED,
"rockset": ROCKSET_REQUIRED,
"ibis": IBIS_REQUIRED,
"duckdb": DUCKDB_REQUIRED
Expand Down

0 comments on commit 4200b9d

Please sign in to comment.