Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PymakeKeyError: 'No substitution for macros...'when the macros are in commented lines #8

Open
smarie opened this issue Jul 24, 2019 · 0 comments · May be fixed by #9
Open

PymakeKeyError: 'No substitution for macros...'when the macros are in commented lines #8

smarie opened this issue Jul 24, 2019 · 0 comments · May be fixed by #9
Assignees
@casperdcl
Labels
enhancement

Comments

@smarie
Copy link

smarie commented Jul 24, 2019

This error seems to happen when you use a macro in a commented line, and the macro name does not exist.

Commented lines in the makefile should probably be removed before processing ?
smarie pushed a commit to smarie/py-make that referenced this issue Jul 24, 2019
Now replacing comments with harmless dummy comments before processing…
87b3975 
… so as to fix bug when they contain reserved expressions. Fixes tqdm#8
@smarie smarie linked a pull request Jul 24, 2019 that will close this issue
Open
@casperdcl casperdcl self-assigned this Aug 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@casperdcl casperdcl

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Now replacing comments with harmless dummy comments before processing… smarie/py-make
2 participants
@smarie @casperdcl