Fix inplace. Only permit shared when shape and dtype is the same (apa…

…che#45)
tqchen · May 29, 2018 · d0cc035 · d0cc035
1 parent 2c0b79a
commit d0cc035
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/nnvm/src/pass/plan_memory.cc b/nnvm/src/pass/plan_memory.cc
@@ -173,7 +173,10 @@ Graph PlanMemory(Graph ret) {
       for (auto& kv : inplace_pairs) {
         uint32_t eid_out = idx.entry_id(nid, kv.second);
         uint32_t eid_in = idx.entry_id(inode.inputs[kv.first]);
-        if (ref_count[eid_in] == 1 && storage[eid_in] != GraphAllocator::kBadStorageID) {
+        if (ref_count[eid_in] == 1 &&
+            storage[eid_in] != GraphAllocator::kBadStorageID &&
+            shape_vec[eid_out].Size() == shape_vec[eid_in].Size() &&
+            dtype_vec[eid_out] == dtype_vec[eid_in]) {
           // inplace optimization
           storage[eid_out] = storage[eid_in];
           ref_count[eid_in] = 0;