Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dependencies that are no longer in java #56

Closed
wants to merge 1 commit into from

Conversation

JonathanKnight
Copy link

Java 9+ no longer includes so dependencies. Add these into the dependency list explicitly.

@tpunder
Copy link
Owner

tpunder commented Feb 26, 2019

What errors are you seeing? We run everything on Java 11 now and haven't run into issues but it's possible we have other SBT plugins that bring in the JABX dependencies.

@tpunder
Copy link
Owner

tpunder commented Feb 26, 2019

Do you know if there is a difference between:

"javax.activation" % "activation" % "1.1.1"
vs
"javax.activation" % "javax.activation-api" % "1.2.0"
vs
"com.sun.activation" % "javax.activation" % "1.2.0"

Here is what we seem to be using in other packages:

"com.sun.xml.bind" % "jaxb-core" % "2.3.0.1",
"com.sun.xml.bind" % "jaxb-impl" % "2.3.1",
"javax.xml.bind" % "jaxb-api" % "2.3.1",
"javax.activation" % "javax.activation-api" % "1.2.0",

@JonathanKnight
Copy link
Author

I have attached
error.txt
the error message I get.
I used this stack overflow answer to add in the jars.
https://stackoverflow.com/questions/43574426/how-to-resolve-java-lang-noclassdeffounderror-javax-xml-bind-jaxbexception-in-j
It did work but I am not sure which jars are better than others, or which are the same with different names.

@tpunder
Copy link
Owner

tpunder commented Feb 27, 2019

Thanks! It looks like this might be a problem in the aws-sdk-java dependency: aws/aws-sdk-java#1863

I'll try upgrading to a newer version to see if that fixes it.

@tpunder
Copy link
Owner

tpunder commented Feb 27, 2019

Can you see if version 0.18.0-SNAPSHOT solves the problem for you?

@tpunder
Copy link
Owner

tpunder commented Feb 27, 2019

The syntax in your plugins.sbt for testing 0.18.0-SNAPSHOT should be something like:

resolvers += Resolver.sonatypeRepo("snapshots")
addSbtPlugin("com.frugalmechanic" % "fm-sbt-s3-resolver" % "0.18.0-SNAPSHOT")

@JonathanKnight
Copy link
Author

Yes works fine - thanks very much for looking at this.

@tpunder
Copy link
Owner

tpunder commented Mar 4, 2019

I've published the fix as 0.18.0

@tpunder tpunder closed this Mar 4, 2019
kenoir added a commit to wellcomecollection/catalogue-pipeline that referenced this pull request Jun 24, 2020
Use the latest version of fm-sbt-s3-resolver to avoid possible issues with missing jaxb deps in Java 11.

See tpunder/fm-sbt-s3-resolver#56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants