Add automatic support for S3 SSE #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This checks to see if your bucket policies prevent the creation of unencrypted files. If so, future PutObject requests will use the SSE request header. This currently assumes you are using AWS KMS-managed encryption keys.
|
What about something like this: 24b57bf I think it accomplishes the same thing but avoids the creation of the tmp object. It basically just tries the PUT as normal and if that fails with a 403 status code then retries with SSE. If the SSE PUT succeeds then it caches that for the next PUT to the bucket. Thoughts? I have my |
|
Looks good! Thanks |
|
This has been published as v0.11.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checks to see if your bucket policies prevent the creation of unencrypted
files. If so, future PutObject requests will use the SSE request header.
This currently assumes you are using AWS KMS-managed encryption keys.