[fix] link custom setting #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create an mkdoc documentation with material plugin
Bumps [jszip](https://github.com/Stuk/jszip) to 3.10.1 and updates ancestor dependency [zip-dir](https://github.com/jsantell/node-zip-dir). These dependencies need to be updated together. Updates `jszip` from 2.7.0 to 3.10.1 <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/Stuk/jszip/blob/main/CHANGES.md">jszip's changelog</a>.</em></p> <blockquote> <h3>v3.10.1 2022-08-02</h3> <ul> <li>Add sponsorship files. <ul> <li>If you appreciate the time spent maintaining JSZip then I would really appreciate <a href="https://github.com/sponsors/Stuk">your sponsorship</a>.</li> </ul> </li> <li>Consolidate metadata types and expose OnUpdateCallback <a href="https://redirect.github.com/Stuk/jszip/pull/851">#851</a> and <a href="https://redirect.github.com/Stuk/jszip/pull/852">#852</a></li> <li>use <code>const</code> instead <code>var</code> in example from README.markdown <a href="https://redirect.github.com/Stuk/jszip/pull/828">#828</a></li> <li>Switch manual download link to HTTPS <a href="https://redirect.github.com/Stuk/jszip/pull/839">#839</a></li> </ul> <p>Internals:</p> <ul> <li>Replace jshint with eslint <a href="https://redirect.github.com/Stuk/jszip/pull/842">#842</a></li> <li>Add performance tests <a href="https://redirect.github.com/Stuk/jszip/pull/834">#834</a></li> </ul> <h3>v3.10.0 2022-05-20</h3> <ul> <li>Change setimmediate dependency to more efficient one. Fixes <a href="https://redirect.github.com/Stuk/jszip/issues/617">Stuk/jszip#617</a> (see <a href="https://redirect.github.com/Stuk/jszip/pull/829">#829</a>)</li> <li>Update types of <code>currentFile</code> metadata to include <code>null</code> (see <a href="https://redirect.github.com/Stuk/jszip/pull/826">#826</a>)</li> </ul> <h3>v3.9.1 2022-04-06</h3> <ul> <li>Fix recursive definition of <code>InputFileFormat</code> introduced in 3.9.0.</li> </ul> <h3>v3.9.0 2022-04-04</h3> <ul> <li>Update types JSZip#loadAsync to accept a promise for data, and remove arguments from <code>new JSZip()</code> (see <a href="https://redirect.github.com/Stuk/jszip/pull/752">#752</a>)</li> <li>Update types for <code>compressionOptions</code> to JSZipFileOptions and JSZipGeneratorOptions (see <a href="https://redirect.github.com/Stuk/jszip/pull/722">#722</a>)</li> <li>Add types for <code>generateInternalStream</code> (see <a href="https://redirect.github.com/Stuk/jszip/pull/774">#774</a>)</li> </ul> <h3>v3.8.0 2022-03-30</h3> <ul> <li>Santize filenames when files are loaded with <code>loadAsync</code>, to avoid <a href="https://snyk.io/research/zip-slip-vulnerability">"zip slip" attacks</a>. The original filename is available on each zip entry as <code>unsafeOriginalName</code>. See the <a href="https://stuk.github.io/jszip/documentation/api_jszip/load_async.html">documentation</a>. Many thanks to McCaulay Hudson for reporting.</li> </ul> <h3>v3.7.1 2021-08-05</h3> <ul> <li>Fix build of <code>dist</code> files. <ul> <li>Note: this version ensures the changes from 3.7.0 are actually included in the <code>dist</code> files. Thanks to Evan W for reporting.</li> </ul> </li> </ul> <h3>v3.7.0 2021-07-23</h3> <ul> <li>Fix: Use a null prototype object for this.files (see <a href="https://redirect.github.com/Stuk/jszip/pull/766">#766</a>) <ul> <li>This change might break existing code if it uses prototype methods on the <code>.files</code> property of a zip object, for example <code>zip.files.toString()</code>. This approach is taken to prevent files in the zip overriding object methods that would exist on a normal object.</li> </ul> </li> </ul> <h3>v3.6.0 2021-02-09</h3> <ul> <li>Fix: redirect main to dist on browsers (see <a href="https://redirect.github.com/Stuk/jszip/pull/742">#742</a>)</li> <li>Fix duplicate require DataLengthProbe, utils (see <a href="https://redirect.github.com/Stuk/jszip/pull/734">#734</a>)</li> <li>Fix small error in read_zip.md (see <a href="https://redirect.github.com/Stuk/jszip/pull/703">#703</a>)</li> </ul> <h3>v3.5.0 2020-05-31</h3> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/Stuk/jszip/commits/v3.10.1">compare view</a></li> </ul> </details> <br /> Updates `zip-dir` from 1.0.2 to 2.0.0 <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/jsantell/node-zip-dir/commits">compare view</a></li> </ul> </details> <br /> Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/tprouvot/Salesforce-Inspector-reloaded/network/alerts). </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
tprouvot
requested changes
May 2, 2023
Co-authored-by: Thomas Prouvot <[email protected]>
Co-authored-by: Thomas Prouvot <[email protected]>
Co-authored-by: Thomas Prouvot <[email protected]>
|
Hello Thomas, Thank you for your feedback and sorry for not having seen ESlint. I just directly committed your suggestions. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Thomas,
This PR fixes the redirection links for custom settings to redirect to the custom setting setup page instead object manager page.
instead
The same goes for object list records for custom setting.
Thank you :)