Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add copy success notification for Field API names #348

Merged

Conversation

dyncan
Copy link
Contributor

@dyncan dyncan commented Mar 13, 2024

Describe your changes

Whenever a user clicks on an API Name after enabling "Show Fields API Names," a notification will pop up confirming that the field has been successfully copied to the clipboard. This immediate feedback ensures users that the copy action was successful.

feat_copyFieldSuccessNotification

Issue ticket number and link

N/A

Checklist before requesting a review

  • I have read and understand the Contributions section
  • Target branch is releaseCandidate and not master
  • I have performed a self-review of my code
  • I ran the unit tests and my PR does not break any tests
  • I documented the changes I've made on the CHANGES.md and followed actual conventions
  • I added a new section on how-to.md (optional)

@dyncan dyncan changed the title feat: add copy success notification for API names feat: add copy success notification for Field API names Mar 13, 2024
@tprouvot
Copy link
Owner

Hi @dyncan thanks for this PR !
I understand the goal and think that it may be useful for users however I'm not a big fan of the UI.
The toast is not really aligned with the extension's UI nor Salesforce.

How about something like this ? (same as the toast, it should disappear few seconds later)

image

@dyncan
Copy link
Contributor Author

dyncan commented Mar 14, 2024

Hi @tprouvot

Thank you for your valuable feedback on the PR!

Taking your feedback into account, I've gone ahead and implemented some UI optimizations, I'd love to hear your thoughts on these updates.

Thank you once again for guiding the improvement process.

@tprouvot
Copy link
Owner

Great thank you for this quick update !
Would you mind create a feature request explaining the goal of this improvement ?
Then reference it in the CHANGES.md file like the other ones.

I'm divided about the message, "copied ✓" looks a little bit weird to me but I like to give the indication to users that the action was a copy (many peeps have no idea about the possibility to copy the field name).
On the other hand, showing only "✓" looks better but don't give the info ...

So here's some options:

  • "Copied ✓"
  • "Copy Success ✓"
  • "Successfully copied"
  • "✓"
image

@dyncan
Copy link
Contributor Author

dyncan commented Mar 14, 2024

Hi @tprouvot, I've created a Feature Request and also updated the CHANGES.md.

Among the options you've provided, I think "Copied ✓" is the most suitable choice. It's concise, clearly communicates the action that has been completed, and the checkmark (✓) provides a universally understood symbol of completion and success.

Thank you.

CHANGES.md Outdated Show resolved Hide resolved
addon/button.js Outdated Show resolved Hide resolved
@tprouvot
Copy link
Owner

Last thing, could you revert the changes applied to package.lock ?

dyncan added 2 commits March 15, 2024 09:04
…can/Salesforce-Inspector-reloaded into feature/copyFieldSuccessNotification
@dyncan
Copy link
Contributor Author

dyncan commented Mar 15, 2024

Hi @tprouvot, Reverted the package-lock.json file.

Thanks!

@tprouvot tprouvot merged commit 8df4e8f into tprouvot:releaseCandidate Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants