Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[data-export] fix : Remove client id from data export #339

Merged
merged 2 commits into from
Mar 6, 2024

Conversation

tprouvot
Copy link
Owner

@tprouvot tprouvot commented Mar 6, 2024

Describe your changes

Entering consumer key from data export was failing since the sf host was null.
Removing the input and keep the normal process on Option page.

Issue ticket number and link

#338

Checklist before requesting a review

  • I have read and understand the Contributions section
  • Target branch is releaseCandidate and not master
  • I have performed a self-review of my code
  • I ran the unit tests and my PR does not break any tests
  • I documented the changes I've made on the CHANGES.md and followed actual conventions
  • I added a new section on how-to.md (optional)

@tprouvot tprouvot changed the base branch from master to releaseCandidate March 6, 2024 16:48
@tprouvot tprouvot merged commit 9fdb773 into releaseCandidate Mar 6, 2024
1 check passed
@tprouvot tprouvot deleted the fix/removeClientIdFromDataExport branch March 22, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant