Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[data-export] Performance display and checkbox toggle common component #287

Merged
merged 39 commits into from
Jan 29, 2024

Conversation

nshulman
Copy link
Contributor

@nshulman nshulman commented Jan 24, 2024

Describe your changes

  • add performance metrics to data export for queries with batch count and min/max/avg time
  • created reusable CheckboxToggle for tab options
  • added Display Query Execution Time checkbox toggle to Data Export tab on options
  • minor cleanup/linting
  • Replaced data export "record(s)" with plural function to display "Exported n records" for 0 or more than 1 record, "Exported 1 record" for 1

Issue ticket number and link

n/a

Checklist before requesting a review

  • [ x ] I have read and understand the Contributions section
  • [ x ] Target branch is releaseCandidate and not master
  • [ x ] I have performed a self-review of my code
  • [ x ] I ran the unit tests and my PR does not break any tests
  • [ x ] I documented the changes I've made on the CHANGES.md and followed actual conventions
  • [ x ] I added a new section on how-to.md (optional)

@tprouvot tprouvot changed the title data export performance display and checkbox toggle [data-export] Performance display and checkbox toggle Jan 24, 2024
@nshulman nshulman changed the title [data-export] Performance display and checkbox toggle [data-export] Performance display and checkbox toggle common component Jan 24, 2024
@tprouvot
Copy link
Owner

Great @nshulman thanks for all those additions 👏

@tprouvot tprouvot merged commit 815f45e into tprouvot:releaseCandidate Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants