Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #218 adding durableId if unset #228

Closed
wants to merge 1 commit into from

Conversation

jefersonchaves
Copy link
Contributor

This is based on my understanding but please feel free to correct me if I'm wrong.

I don't understand yet unit tests for Chrome Extensions, so, I need some guidance there if needed.

@tprouvot
Copy link
Owner

Hi @jefersonchaves nice catch ! 👏

As describe in the contribution section from the readme, could you create your branch from releaseCandidate and create a PR to this branch ?
Also could you describe the fix you've made on the CHANGES.md file by following the current convention ?

Thanks a lot !

@jefersonchaves jefersonchaves deleted the patch-1 branch November 16, 2023 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants