Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto detect import externalId field #178

Merged
merged 3 commits into from
Mar 19, 2024

Conversation

dufoli
Copy link
Contributor

@dufoli dufoli commented Oct 17, 2023

fix #26

@dufoli
Copy link
Contributor Author

dufoli commented Oct 18, 2023

I have test it and it works. Need a review and merge.

@dufoli
Copy link
Contributor Author

dufoli commented Oct 18, 2023

maybe we can even improove it by adding a magic wand matching
and provide an advance guess where we check with

  • lower case equal
  • field name contain column name

but we need a validation layout with:
original name and column name proposition with a validation.

wdyt ?
anyway it need a new issue for that.

@tprouvot
Copy link
Owner

Hi @dufoli,
Thanks for the PR !

Could you create your branch from releaseCandidate and use this target branch when updating the PR ?
Also could you reference your change in CHANGES.md file following current convention ?
Thanks

@dufoli dufoli changed the base branch from master to releaseCandidate October 18, 2023 17:09
@dufoli dufoli force-pushed the issue-26 branch 2 times, most recently from f6e4c98 to 637a450 Compare October 18, 2023 17:21
@dufoli
Copy link
Contributor Author

dufoli commented Oct 18, 2023

@tprouvot that s done ;-)

@tprouvot
Copy link
Owner

Hi @dufoli ,

I'm facing an issue during my tests, could you have a check ?
Thanks !

2023-10-20_10-20-14 (1)

@dufoli
Copy link
Contributor Author

dufoli commented Oct 20, 2023

J'ai corrigé.

@dufoli
Copy link
Contributor Author

dufoli commented Oct 20, 2023

I have improved it by adding a refresh function in order to guess all column after change of object type (by selection or auto selection when it is guessed from first column of import.

@dufoli
Copy link
Contributor Author

dufoli commented Oct 20, 2023

ready for new review

@dufoli
Copy link
Contributor Author

dufoli commented Nov 2, 2023

rebase

@dufoli
Copy link
Contributor Author

dufoli commented Nov 10, 2023

@tprouvot any news for review ?

CHANGES.md Outdated Show resolved Hide resolved
addon/data-import.js Outdated Show resolved Hide resolved
@tprouvot
Copy link
Owner

@dufoli
Is the PR ready to test ?

@dufoli
Copy link
Contributor Author

dufoli commented Dec 27, 2023

Yes

@dufoli
Copy link
Contributor Author

dufoli commented Dec 27, 2023

I have take another look and see that i remove trim by mistake

@tprouvot
Copy link
Owner

tprouvot commented Jan 2, 2024

Hey @dufoli happy new year !
Sorry but the auto detect does not work anymore, could you have a check ?

@dufoli dufoli force-pushed the issue-26 branch 2 times, most recently from ee2a100 to 3b597f8 Compare January 3, 2024 12:03
@dufoli
Copy link
Contributor Author

dufoli commented Jan 3, 2024

hello, I have recheck. It is a matter of async call of describeInfo because didUpdate do nothing and when we call for first time cache of object is empty. So I have change the way of update by doing it in async way if didupdate is call and in direct way if already present.

@tprouvot tprouvot deleted the branch tprouvot:releaseCandidate January 12, 2024 13:36
@tprouvot tprouvot closed this Jan 12, 2024
@tprouvot tprouvot reopened this Jan 12, 2024
@tprouvot tprouvot merged commit 6922599 into tprouvot:releaseCandidate Mar 19, 2024
@Dufgui Dufgui deleted the issue-26 branch May 12, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feat] Import : format relations as expected on paste
2 participants