-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[data-export] Input focus on SOQL query field #153
Conversation
Hi @asknet Could you add the new feature description in CHANGES.md file ? (following current convention) Could you condition this focus based on a localStorage variable (by default false) ? We should have an option page where users will be able to enable / disable features from this page. Thanks a lot ! |
Thanks for the feedback. Sure, I will update the |
@asknet |
I came in here to create a pull request for this exact feature myself:) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @asknet,
I changed my mind, we can enable this param by default and it can be used to disable it.
Could you accept the suggested changes and also update the CHANGES.md file ?
Thank you !
Co-authored-by: Thomas Prouvot <[email protected]>
@tprouvot Thank you. I updated it. Kindly, review. |
Problem statement:
Whenever I open data export, the query text area isn't focused. It requires another click to set focus and then start typing.
Solution:
This PR allows to set query textarea as focus on load.
Also new to reactjs development. Please review and suggest.