Proposal - Inspect page restyling #105
Conversation
|
Hi @pietromartino thanks for this PR ! Few small suggestions:
Last but not least, I updated the background image and screen when the org is a prod to warn the user that his actions may have big consequences 😄 Since we can update data on this page it would be nice to have the same functionality, what do you think ? |
|
Since this is a major change to UI and from feedbacks I had, I think it would be great to let users decide or configure if they want to have table borders or not. We would use the localStore to store the user preference with a property named 'displayInspectTableBorders' |
|
Hi @tprouvot , that's a very good point! I added a settings option to the table to allow users to add / remove borders. |
| updateShowTableBorder() { | ||
| this.showTableBorder = !this.showTableBorder; | ||
| localStorage.setItem("displayInspectTableBorders", "true"); // Save to local storage | ||
|
|
|
Hi @pietromartino thanks for this great PR ! Could you merge release candidate in your branche since there was a new released between your branch creation and now ? |
|
Hi @tprouvot, I rebased the branch and centered the buttons in the edit footer bar! Give it a look when you can :) |
There was a problem hiding this comment.
Hi @pietromartino,
Thanks for the updates !
Could you check the rebase you've made ?
Because in the files changes we have some updates that are already in releaseCandidate branch (Version 1.19 updates from CHANGES.md, export query code, pset group button etc.)
Could you also add the Inspect restyling in the CHANGES ?
Thanks !
Co-authored-by: Thomas Prouvot <[email protected]>
pietromartino
force-pushed
the
feature/inspectRestyling
branch
from
9e42a6c to
9669c2b
Compare
|
Hi @tprouvot, you're right! There were some merge errors- should be solved now. |
|
Thank you very much @pietromartino ! 👏 |
Version 1.19 =========== General ------- * Inspect Page Restyling (UI improvements, red background for PROD, display / hide table borders) [PR105](#105) (contribution by [Pietro Martino](https://github.com/pietromartino)) * Navigate to record detail (Flows, Profiles and PermissionSet) from shortcut search [feature 118](#118) * Fix country codes from LocalSidKey convention [PR117](#117) (contribution by [Luca Bassani](https://github.com/baslu93)) * Use custom shortcuts [feature 115](#115) * Add Export Query button [feature 109](#109) (idea by [Ryan Sherry](https://github.com/rpsherry-starburst)) * Add permission set group assignment button from popup [feature 106](#106)
Proposed restyling for the inspect record page. Main highlights: