Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[options] Add a tooltip to Option component #399

Closed
tprouvot opened this issue Apr 24, 2024 · 1 comment
Closed

[options] Add a tooltip to Option component #399

tprouvot opened this issue Apr 24, 2024 · 1 comment
Labels
enhancement New feature or request work in progress Someone is working on this issue

Comments

@tprouvot
Copy link
Owner

Is your feature request related to a problem? Please describe.
Some options may need extra information, it would be great to have a tooltip to give more info

image

Describe the solution you'd like
This tooltip property needs to be added to the Option class in options.js file

class Option extends React.Component {
  constructor(props) {
    super(props);
    this.onChange = this.onChange.bind(this);
    this.onChangeToggle = this.onChangeToggle.bind(this);
    this.key = props.storageKey;
    this.type = props.type;
    this.label = props.label;
    this.placeholder = props.placeholder;
    this.tooltip = props.tooltip;

Additional context
We would need to add slds-popover slds-popover_tooltip classes to slds.css

@tprouvot tprouvot added the enhancement New feature or request label Apr 24, 2024
@tprouvot tprouvot self-assigned this Apr 24, 2024
@tprouvot tprouvot added help wanted You can work on this issue if you want to ! and removed help wanted You can work on this issue if you want to ! labels Apr 24, 2024
@tprouvot tprouvot removed their assignment Apr 30, 2024
@tprouvot
Copy link
Owner Author

Thank you for handling this one @nshulman !

@tprouvot tprouvot added the work in progress Someone is working on this issue label Apr 30, 2024
tprouvot pushed a commit that referenced this issue May 15, 2024
#423)

## Describe your changes
- Cleaned up all ESLint issues
- Added more status to test framework
- Updated Firefox Instructions, fixed bugs specific to Firefox
- Added nullToEmptyString to prevent React error (null value on input)
- Updated SVG file to latest
- Added `docs/dev-notes.md` for contributors
- Added tooltip to options feature request
- Fixed 100% popup off screen issue

## Issue ticket number and link
[popup] Setting the "Popup arrow button orientation and position" to
100% makes it invisible [issue
404](#404)
[options] Add a tooltip to Option component [feature
399](#399)

## Checklist before requesting a review
- [ x ] I have read and understand the [Contributions
section](https://github.com/tprouvot/Salesforce-Inspector-reloaded#contributions)
- [ x ] Target branch is releaseCandidate and not master
- [ x ] I have performed a self-review of my code
- [ x ] I ran the [unit
tests](https://github.com/tprouvot/Salesforce-Inspector-reloaded#unit-tests)
and my PR does not break any tests
- [ x ] I documented the changes I've made on the
[CHANGES.md](https://github.com/tprouvot/Salesforce-Inspector-reloaded/blob/master/CHANGES.md)
and followed actual conventions
- [ ] I added a new section on
[how-to.md](https://github.com/tprouvot/Salesforce-Inspector-reloaded/blob/master/docs/how-to.md)
(optional)

---------

Co-authored-by: nshulman <[email protected]>
Co-authored-by: Nathan Shulman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request work in progress Someone is working on this issue
Projects
None yet
Development

No branches or pull requests

1 participant