Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the escape (esc) key to exit popup #378

Closed
ktag3000 opened this issue Apr 5, 2024 · 3 comments
Closed

Use the escape (esc) key to exit popup #378

ktag3000 opened this issue Apr 5, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@ktag3000
Copy link

ktag3000 commented Apr 5, 2024

When the popup is open can you also allow it to be closed by pressing the escape key? It closes for a mouse click on the screen already, which is great.

@ktag3000 ktag3000 added the enhancement New feature or request label Apr 5, 2024
@tprouvot
Copy link
Owner

tprouvot commented Apr 8, 2024

Good idea I'll take a look 👍

gramier added a commit to gramier/Salesforce-Inspector-reloaded that referenced this issue Apr 21, 2024
tprouvot added a commit that referenced this issue Apr 22, 2024
## Added Escape Shortcut to Quit popup

## Issue ticket 378

## Checklist before requesting a review
- [X ] I have read and understand the [Contributions
section](https://github.com/tprouvot/Salesforce-Inspector-reloaded#contributions)
- [X ] Target branch is releaseCandidate and not master
- [X ] I have performed a self-review of my code
- [ ] I ran the [unit
tests](https://github.com/tprouvot/Salesforce-Inspector-reloaded#unit-tests)
and my PR does not break any tests
- [X ] I documented the changes I've made on the
[CHANGES.md](https://github.com/tprouvot/Salesforce-Inspector-reloaded/blob/master/CHANGES.md)
and followed actual conventions
- [ ] I added a new section on
[how-to.md](https://github.com/tprouvot/Salesforce-Inspector-reloaded/blob/master/docs/how-to.md)
(optional)

---------

Co-authored-by: Thomas Prouvot <[email protected]>
@tprouvot
Copy link
Owner

@ktag3000 will be released in the 1.24 🚀

@ktag3000
Copy link
Author

Awesome! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants