Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure default values for Batch Size and Threads in Data import #329

Closed
ritterblau opened this issue Mar 4, 2024 · 2 comments
Closed
Assignees
Labels
enhancement New feature or request

Comments

@ritterblau
Copy link

Is your feature request related to a problem? Please describe.

When importing, by default they are done at Batch size 200 and Threads 6
image

This can be modified from the data-import.js file, but updating the extension resets it.
image

Would it be possible to configure it from the configuration?

@ritterblau ritterblau added the enhancement New feature or request label Mar 4, 2024
tprouvot added a commit that referenced this issue Mar 5, 2024
## Describe your changes
Add the batchSize and thread size to the configurable options.

## Issue ticket number and link
#329 

## Checklist before requesting a review
- [x] I have read and understand the [Contributions
section](https://github.com/tprouvot/Salesforce-Inspector-reloaded#contributions)
- [x] Target branch is releaseCandidate and not master
- [x] I have performed a self-review of my code
- [x] I ran the [unit
tests](https://github.com/tprouvot/Salesforce-Inspector-reloaded#unit-tests)
and my PR does not break any tests
- [x] I documented the changes I've made on the
[CHANGES.md](https://github.com/tprouvot/Salesforce-Inspector-reloaded/blob/master/CHANGES.md)
and followed actual conventions
- [ ] I added a new section on
[how-to.md](https://github.com/tprouvot/Salesforce-Inspector-reloaded/blob/master/docs/how-to.md)
(optional)
@tprouvot
Copy link
Owner

tprouvot commented Mar 5, 2024

Will be released in 1.23 🚀
And sooner in the beta version

@tprouvot tprouvot closed this as completed Mar 5, 2024
@ritterblau
Copy link
Author

Thanks a lot @tprouvot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants